feat(cwgrants): Implement x/cwgrants module #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 65.61% 64.50% -1.12%
==========================================
Files 80 88 +8
Lines 4633 4851 +218
==========================================
+ Hits 3040 3129 +89
- Misses 1436 1556 +120
- Partials 157 166 +9 ☔ View full report in Codecov by Sentry. |
fdymylja
commented
Jan 2, 2024
spoo-bar
reviewed
Jan 5, 2024
# Conflicts: # CHANGELOG.md # app/app.go # app/keepers/keepers.go # app/upgrades/latest/upgrades.go
zanicar
reviewed
Jan 16, 2024
zanicar
reviewed
Jan 16, 2024
zanicar
reviewed
Jan 16, 2024
zanicar
reviewed
Jan 16, 2024
| // SudoMsg defines the message sudo enum that is sent to the CosmWasm contract. | ||
| type SudoMsg struct { | ||
| // CWGrant defines the enum variant of the grant message. | ||
| CWGrant *CWGrant `json:"cw_grant"` |
There was a problem hiding this comment.
I think CWGrant is fine here, whilst the "module name" is CWFees (as it handles fees); what is being sent as request here is a request for a fee grant.
The name is kept as short as possible to avoid extra gas consumption when we traverse the wasm boundary.
zanicar
requested changes
Jan 16, 2024
|
@zanicar I would propose we keep as is, and consider renaming this cwfeegrants, to be in line with cosmos sdk's fee grant module, at nomenclature level, I will create an issue. |
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.